-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67500
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 9, 2015, 11:38 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29770/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 11:38 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-970 and AURORA-989
>     https://issues.apache.org/jira/browse/AURORA-970
>     https://issues.apache.org/jira/browse/AURORA-989
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add support for --version flag to client.
> 
> Right now it just prints out the version from .auroraversion. We no longer 
> print out the build sha/date from PEX_INFO.
> 
> The one wonky thing here is that in order to read .auroraversion from the 
> client, I'm symlinking it under src/main/aurora/apache/client/cli. Open to 
> better solutions if anyone can think of something.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/.auroraversion PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/BUILD 
> c7ca61dc5ffc18c95820d38d55228ffad58412ea 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 29998833b50cca2c10eb5c248de9ee1cb60c7a5c 
>   src/test/python/apache/aurora/client/cli/test_version.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29770/diff/
> 
> 
> Testing
> -------
> 
> ./pants build src/test/python/apache/aurora/client::
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to