----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/#review67689 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On Jan. 12, 2015, 7:53 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29717/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 7:53 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > ------- > > This patch removes the dynamic hooks functionality and dynamic hook policy > mechanism from the client. As far as I can tell they are currently unused and > add a lot of complexity to the client. > > > Diffs > ----- > > docs/design/command-hooks.md cc56218625edfd1b255f1ca18ae91c32e2dcccef > src/main/python/apache/aurora/client/cli/__init__.py > 6e553d8af459e575b2d62282a3bc0d1e266203d8 > src/main/python/apache/aurora/client/cli/command_hooks.py > aa850bf941bede1d3bd8aae4811cb094ba77965f > src/test/python/apache/aurora/client/cli/AuroraHooks > e27fcc81d6092b3b42f9a2948e3955d8f6963a14 > > src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks > 9a221591250f4d0d3b1b75f90b8b4cf8f95ee4b9 > > src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks > 5dc5907b9ae87632f91084e43be319c6f1b4f437 > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 > > Diff: https://reviews.apache.org/r/29717/diff/ > > > Testing > ------- > > ./pants build --timeout=60 > src/test/python/apache/aurora/client/cli:command_hooks -vxs > > > Thanks, > > Zameer Manji > >