----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67712 -----------------------------------------------------------
@ReviewBot retry - Bill Farner On Jan. 12, 2015, 6:56 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29770/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 6:56 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-970 and AURORA-989 > https://issues.apache.org/jira/browse/AURORA-970 > https://issues.apache.org/jira/browse/AURORA-989 > > > Repository: aurora > > > Description > ------- > > Add support for --version flag to client. > > Right now it just prints out the version from .auroraversion. We no longer > print out the build sha/date from PEX_INFO. > > The one wonky thing here is that in order to read .auroraversion from the > client, I'm symlinking it under src/main/aurora/apache/client/cli. Open to > better solutions if anyone can think of something. > > > Diffs > ----- > > .auroraversion e8ff9d45c6326c28dae836a1409ec0c9b00fd75a > .auroraversion PRE-CREATION > BUILD 992f6750a97a4f0224dbfb8d4ecc5abeb976af69 > examples/vagrant/provision-dev-cluster.sh > 490a8194424d4adddc2d9b3a7a7f0e579bea6c06 > src/main/python/apache/aurora/client/cli/BUILD > c7ca61dc5ffc18c95820d38d55228ffad58412ea > src/main/python/apache/aurora/client/cli/__init__.py > 29998833b50cca2c10eb5c248de9ee1cb60c7a5c > src/main/resources/apache/aurora/client/cli/.auroraversion PRE-CREATION > src/main/resources/apache/aurora/client/cli/BUILD PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 407cda9a374c37ec3905e09c2a51f3737a335eec > src/test/python/apache/aurora/client/cli/test_version.py PRE-CREATION > src/test/sh/org/apache/aurora/e2e/test_common.sh > 31646425233470b5f87ab50ef4504264f235f48a > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > 578662ccd1735ebf500d066b3cc17b30f635c15f > > Diff: https://reviews.apache.org/r/29770/diff/ > > > Testing > ------- > > Ran on my (mac) laptop and within the vagrant image: > ./pants build src/test/python:all > ./gradlew clean build > > Also ran e2e tests: > > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Joshua Cohen > >
