> On Jan. 12, 2015, 11:35 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line > > 100 > > <https://reviews.apache.org/r/29828/diff/1/?file=818229#file818229line100> > > > > nit: should this be 2 spaces, not 4?
indentation is 2, continuations are typically 4. > On Jan. 12, 2015, 11:35 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/common/resource_manager.py, line 1 > > <https://reviews.apache.org/r/29828/diff/1/?file=818231#file818231line1> > > > > Add license header to all these new files. done - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/#review67744 ----------------------------------------------------------- On Jan. 12, 2015, 11:25 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29828/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 11:25 p.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Bugs: AURORA-1002 > https://issues.apache.org/jira/browse/AURORA-1002 > > > Repository: aurora > > > Description > ------- > > Patch ResourceManager into OSS Aurora. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/bin/BUILD > 0434c7ba480a80a9722e626775cf5c3adbc3e68e > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 > src/main/python/apache/aurora/executor/common/BUILD > 142ec0d42b2cb31dcef1e32768e9ea5286355913 > src/main/python/apache/aurora/executor/common/resource_manager.py > PRE-CREATION > src/test/python/apache/aurora/executor/common/BUILD > 2bf6b2df4761acaa88c38868f03e686ec6b42ab7 > src/test/python/apache/aurora/executor/common/test_resource_manager.py > PRE-CREATION > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/29828/diff/ > > > Testing > ------- > > Ran e2e v1 tests which broke, but not because of the RM wiring. Running e2e2 > tests now. > > > Thanks, > > Brian Wickman > >