> On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, > > line 21 > > <https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21> > > > > same, this doesn't appear to be related to a pants upgrade > > Brian Wickman wrote: > this is to fix the test failure brought up by reviewbot. unclear if it's > related to the pants upgrade, but it should be fixed regardless. > > Brian Wickman wrote: > would you prefer that this go into a separate review? > > Kevin Sweeney wrote: > Yes, I prefer to keep commits small and focused (if I revert a commit > titled "upgrade pants" I don't expect it to also break an unrelated test). > Sorry if my comment made that unclear.
If the failure is caused by the pants upgrade, then it should ship w/ this review. If it's just an oversight from the initial commit of the resource manager, then split it out? - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67988 ----------------------------------------------------------- On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29866/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 12:15 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Ports aurora repo to use pants 0.0.27 using the new pants new command > processor. > > > Diffs > ----- > > .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 > build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 > build-support/pants_requirements.txt > 9a790f973cc7560980d43d5a1097338ff88a0397 > build-support/python/make-pycharm-virtualenv > 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 > build-support/python/update-pants-requirements > 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 > build-support/release/make-python-sdists > 2f437d33928cc429a79aedb00247d472953fbb95 > docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd > examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd > pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 > src/main/python/apache/aurora/executor/common/resource_manager.py > bf69e7e60ae4dd857243d8b040a70daca008ea28 > > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py > e3c766f9b7bf989c0790281231957947d2cda52a > src/test/python/apache/aurora/executor/test_thermos_executor.py > 503e62f4cac872b14f6985b5bccc3e4dfcf81789 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py > f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c > > Diff: https://reviews.apache.org/r/29866/diff/ > > > Testing > ------- > > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Brian Wickman > >
