----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30000/#review68524 -----------------------------------------------------------
Ship it! LGTM, but i really think we should reject unreasonably-small tasks rather than silently modifying them. Please file a ticket to address that way. This has the bonus of reducing complexity in our code. - Bill Farner On Jan. 17, 2015, 1:08 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30000/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 1:08 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1021 > https://issues.apache.org/jira/browse/AURORA-1021 > > > Repository: aurora > > > Description > ------- > > This increase will prevent jobs with small resource requirements from OOMing > if > there is no executor overhead. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > 5bf283062c9d119ff91ed45da8b236e36d0fc9aa > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30000/diff/ > > > Testing > ------- > > ./gradlew clean test > > > Thanks, > > Zameer Manji > >
