----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review68763 -----------------------------------------------------------
Master (c37de9a) is red with this patch. ./build-support/jenkins/build.sh :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java:16:8: Unused import - com.google.common.base.Predicate. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java:22:8: Unused import - com.twitter.common.base.MorePreconditions. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java:36: Wrong order for 'java.util.Set' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java:40: Using the '.*' form of import should be avoided - org.apache.aurora.scheduler.configuration.ConfigurationManager.*. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleTest'. > Checkstyle rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 41.161 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 20, 2015, 7:21 p.m., Florian Pfeiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30010/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 7:21 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-184 > https://issues.apache.org/jira/browse/AURORA-184 > > > Repository: aurora > > > Description > ------- > > [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints > > This is the first step for AURORA-184, that removes the default host&rack > limit constraints. > The second step that's still missing would be to add s.th. like > "--default-constraints" as start parameter to the scheduler. > > AURORA-174 could probably be closed with this?(since the rack limit > constraint can be configured in the .aurora file) > > I can't really estimate the effect of my changes in > StorageBackfillTest&SchedulerThriftInterfaceTest, please have a closer look > at the changes I did there. > > Since this is also my first code submit, comments about codestyle&other bad > habbits are very appreciated. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 01b03508afac37b5a8f0ec5c3da1460695e1ef59 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java > 7eafe074b686d55ad96018006cf4acfa823513c3 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > ad9126c32893080e128d086ea3bfd7ad23d27b89 > > Diff: https://reviews.apache.org/r/30010/diff/ > > > Testing > ------- > > Added test for ConfigurationManager.hasName > Added test testNoHostAndRackConstraintsAdded, that checks if the constraints > are present > Tested on vagrant devcluster to see if constraints are also gone in "real > life" > > > Thanks, > > Florian Pfeiffer > >
