-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review69460
-----------------------------------------------------------
Master (3fa004b) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.config
..... SUCCESS
src.test.python.apache.aurora.client.cli.cron
..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect
..... SUCCESS
src.test.python.apache.aurora.client.cli.job
..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins
..... SUCCESS
src.test.python.apache.aurora.client.cli.quota
..... SUCCESS
src.test.python.apache.aurora.client.cli.sla
..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate
..... SUCCESS
src.test.python.apache.aurora.client.cli.task
..... SUCCESS
src.test.python.apache.aurora.client.cli.update
..... SUCCESS
src.test.python.apache.aurora.client.cli.version
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.config.test_base
..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
..... SUCCESS
src.test.python.apache.aurora.config.test_loader
..... SUCCESS
src.test.python.apache.aurora.config.test_thrift
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.aurora.executor.executor_base
..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector
..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars
..... SUCCESS
src.test.python.apache.aurora.executor.status_manager
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
..... FAILURE
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Jan. 23, 2015, 8:37 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30225/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2015, 8:37 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-1010
> https://issues.apache.org/jira/browse/AURORA-1010
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added pulsing support into the JobUpdateController. The qualified coordinated
> updates get blocked until a pulse arrives. An update then becomes active and
> proceeds until `blockIfNoPulsesAfterMs` expires or the update reaches a
> terminal state (whichever comes first).
>
> Not particularly happy with plumbing through OneWayJobUpdater but the
> alternative is a state machine change, which is much hairier and will require
> more changes in the JobUpdaterController. Going with the minimal diff here.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java
> d3b30d48b76d8d7c64cda006a34f7ed3296526f2
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
> a992938d4e12b20f81608be6bbdc24c0a211c3fd
> src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java
> 27a5b9026f5ac3b3bdeb32813b10435bc3dab173
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
> 4c827b183a87b4d97774edbfaa960bd1c3de72a5
> src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java
> 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987
>
> Diff: https://reviews.apache.org/r/30225/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
