-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69478
-----------------------------------------------------------
Master (e3b8905) is red with this patch.
./build-support/jenkins/build.sh
Running setup.py install for twitter.common.collections
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
Running setup.py install for smmap
Running setup.py install for twitter.common.string
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.string-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.options
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.options-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.dirutil
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.contextutil
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.contextutil-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.lang
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.0-py2.7-nspkg.pth
Successfully installed twitter.checkstyle pyflakes pep8 GitPython
twitter.common.app gitdb twitter.common.process twitter.common.log
twitter.common.util twitter.common.collections smmap twitter.common.string
twitter.common.options twitter.common.dirutil twitter.common.contextutil
twitter.common.lang
Cleaning up...
T001:ERROR src/main/python/apache/aurora/common/clusters.py:034 Class globals
must be UPPER_SNAKE_CASED
| name = Required(String)
F401:ERROR src/test/python/apache/aurora/common/test_clusters.py:021 'Parser'
imported but unused
|from apache.aurora.common.clusters import Clusters, Parser
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30187/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 9:09 p.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1029
> https://issues.apache.org/jira/browse/AURORA-1029
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove support for cluster metadata in YAML format.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/clusters.py
> e55aa774b4b868f696a7de51bb016f950871dd1e
> src/test/python/apache/aurora/common/BUILD
> 14165b96be99b8de418f4bb8def9f27eaf29e67d
> src/test/python/apache/aurora/common/test_clusters.py
> 45250e609cca1149dc296b2aaf645ff2f58f8288
>
> Diff: https://reviews.apache.org/r/30187/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> test_end_to_end.sh is currently broken on master, i will address that and
> ensure it passes before committing this.
>
>
> Thanks,
>
> Bill Farner
>
>