> On Jan. 27, 2015, 10:32 p.m., Kevin Sweeney wrote:
> > Any idea which change introduced this breakage? Can you elaborate in the 
> > description?

Sorry yeah, I was writing up an email to the dev list.  I'll just post here 
instead.  I actually was the one who broke this with a tiny change in 
[28920](https://reviews.apache.org/r/28920/#review69480).  The unit test didn't 
have the job set on the AssignedTask object, so it failed trying to read it 
when creating the sandbox.

The actual error the test was failing with was:
```
FATAL] Task killed during initialization.
                     Traceback (most recent call last):
                       File 
"/tmp/tmpOboqH_/.deps/twitter.common.exceptions-0.3.2-py2-none-any.whl/twitter/common/exceptions/__init__.py",
 line 126, in _excepting_run
                         self.__real_run(*args, **kw)
                       File 
"/tmp/tmpOboqH_/.deps/twitter.common.concurrent-0.3.2-py2-none-any.whl/twitter/common/concurrent/deferred.py",
 line 43, in run
                         self._closure()
                       File 
"/tmp/tmpOboqH_/apache/aurora/executor/aurora_executor.py", line 252, in 
<lambda>
                         defer(lambda: self._run(driver, assigned_task))
                       File 
"/tmp/tmpOboqH_/apache/aurora/executor/aurora_executor.py", line 96, in _run
                         self._runner = 
self._runner_provider.from_assigned_task(assigned_task, self._sandbox)
                       File 
"/tmp/tmpOboqH_/apache/aurora/executor/thermos_task_runner.py", line 382, in 
from_assigned_task
                         role = self._get_role(assigned_task)
                       File 
"/tmp/tmpOboqH_/apache/aurora/executor/thermos_task_runner.py", line 378, in 
_get_role
                         return None if assigned_task.task.container.docker 
else assigned_task.task.job.role
                     AttributeError: 'NoneType' object has no attribute 'role'
```
however, it never got bubbled back to the unit test, and the test instead hung 
at `proxy_driver.wait_stopped()`


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30331/#review69902
-----------------------------------------------------------


On Jan. 27, 2015, 10:28 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30331/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 10:28 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixed python tests hanging
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> e6191f3e7775663ad4a75546b5e86289bb73e989 
> 
> Diff: https://reviews.apache.org/r/30331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Reply via email to