----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/#review70316 -----------------------------------------------------------
Ship it! src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java <https://reviews.apache.org/r/30433/#comment115419> Suggest adding an explanation of what active update means, e.g.: "An update in one of the following states is considered active" + ACTIVE_JOB_UPDATE_STATES. Otherwise, it can be unclear why PAUSED update prevents from creating a new one. - Maxim Khutornenko On Jan. 30, 2015, 12:21 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30433/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 12:21 a.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1023 > https://issues.apache.org/jira/browse/AURORA-1023 > > > Repository: aurora > > > Description > ------- > > This adds a guard before an update is saved to make sure we don't already > have an active update for the given job. This was an implied invariant due > to the relationship between the locks table and job updates table, but that > relationship can be compromised by outside user action. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > a992938d4e12b20f81608be6bbdc24c0a211c3fd > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 4c827b183a87b4d97774edbfaa960bd1c3de72a5 > > Diff: https://reviews.apache.org/r/30433/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
