----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70655 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/30325/#comment115972> You can check whether the primitive field is set, which will distinguish between default int value and an explicitly set value. I think it makes sense to reject zero at this layer. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/30325/#comment115976> This is too restrictive. It means that _only_ the update coordinator role may call this RPC, and that a user cannot build something to pulse their own updates. You should instead do what `isAdmin` does and fall back to the coordinator role if direct auth fails. This is an unfortunate state of affairs, and hopefully the move to shiro dramatically improves all this. - Bill Farner On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30325/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 5:23 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. > > > Bugs: AURORA-1009 > https://issues.apache.org/jira/browse/AURORA-1009 > > > Repository: aurora > > > Description > ------- > > Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin > interface to support AOP capability validation. > > The RB is diffed against https://reviews.apache.org/r/30225/ > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > 4f603f9e7ed004e53937a45ea8edf7241e15f5cf > src/main/java/org/apache/aurora/auth/CapabilityValidator.java > 45ef643ebe57c1517cdae373574331ea302a8b74 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 8c19f3b08135eb5f3098591ebf9931b42a086318 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 > > Diff: https://reviews.apache.org/r/30325/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
