-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review70913
-----------------------------------------------------------
Master (8bcb2ba) is red with this patch.
./build-support/jenkins/build.sh
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
../compiler/cpp/thrift --gen html -r ../tutorial/tutorial.thrift
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make: Leaving directory
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:classesThriftNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java:166:
error: cannot find symbol
storeProvider.getJobUpdateStore().fetchJobUpdateSummaries(queryByJob(job));
^
symbol: method queryByJob(IJobKey)
1 error
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 19.808 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 4, 2015, 2:29 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30225/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:29 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-1010
> https://issues.apache.org/jira/browse/AURORA-1010
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added pulsing support into the JobUpdateController. The qualified coordinated
> updates get blocked until a pulse arrives. An update then becomes active and
> proceeds until `blockIfNoPulsesAfterMs` expires or the update reaches a
> terminal state (whichever comes first).
>
> Not particularly happy with plumbing through OneWayJobUpdater but the
> alternative is a state machine change, which is much hairier and will require
> more changes in the JobUpdaterController. Going with the minimal diff here.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> 4f603f9e7ed004e53937a45ea8edf7241e15f5cf
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java
> 7f2ec71d744d5fafac84291cc79feba3398d0e1e
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java
> b7d8d524e15f101416889c00efc3ecf2c8d9c1a1
> src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java
> d479d20259f284528b2291e2e486b36d8e47fe5e
>
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
> 60f535988a20638fb16515d5027bfa65f1afb73c
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java
> d3b30d48b76d8d7c64cda006a34f7ed3296526f2
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
> ec9d1e07abca1bf30262e1c0f741a34741e96f5d
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java
> 76460f95e058181b711fb6869f5a34c1d5bdfe31
> src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java
> 27a5b9026f5ac3b3bdeb32813b10435bc3dab173
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
> f9c9ceddc559b43b4a5c45c745d54ff47484edde
>
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
> ca7c0c2675477cc727ca006697665f997972dfde
>
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
> 89765ac3d34a827d3748fb96a275d78e9d1b8b72
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
> 41d422939209d0808235128e4242c11e8ef25969
> src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java
> 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987
>
> Diff: https://reviews.apache.org/r/30225/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
