----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71137 -----------------------------------------------------------
src/test/python/apache/aurora/executor/common/test_health_checker.py <https://reviews.apache.org/r/30647/#comment116768> Any chance to have test coverage for the other two metrics? - Maxim Khutornenko On Feb. 5, 2015, 1:46 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30647/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 1:46 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1062 > https://issues.apache.org/jira/browse/AURORA-1062 > > > Repository: aurora > > > Description > ------- > > Instrument the HealthChecker to export stats. > > HealthChecker plugin now should export three stats: > consecutive_failures: number of consecutive failures experienced (resets on > success) > latency: how long health checks are taking in practice > snoozed: whether or not the health checker is snoozed > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/health_checker.py > 60676ba0fbd8a218fe4309f07de28e2c66d54530 > src/main/python/apache/aurora/executor/common/status_checker.py > 624921d68199df098ea51ee8a10815403bf58984 > src/test/python/apache/aurora/executor/common/test_health_checker.py > def249c2509a28f7145380f250f79202b653dc83 > > Diff: https://reviews.apache.org/r/30647/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common:: > > > Thanks, > > Brian Wickman > >
