-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30704/#review71355
-----------------------------------------------------------

Ship it!


Master (1c78721) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 6, 2015, 1:19 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30704/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 1:19 a.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-1024
>     https://issues.apache.org/jira/browse/AURORA-1024
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> To allow for an API that will allow for multiple thermos roots it would be 
> best to remove the default root in TaskPath. This way code that does not 
> explictly pass in a root will cause an exception.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 890bfaa28f1e72d283958659598befee8f47c7b7 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7b346e253677ee9b42c57782f7f67ff63b6a0083 
>   src/main/python/apache/thermos/bin/thermos.py 
> ebf5488a76f8f1199972532118fda61b411df3bd 
>   src/main/python/apache/thermos/common/BUILD 
> 6015f9e9a23f71bf6dede1f4698fe63dbb4dcfaa 
>   src/main/python/apache/thermos/common/constants.py PRE-CREATION 
>   src/main/python/apache/thermos/common/path.py 
> 9e617051f16f4270b3958f48e0cc43706d245eec 
>   src/main/python/apache/thermos/observer/bin/thermos_observer.py 
> 53c331c221b84bef4f2ab80829d51347c6232ad7 
>   src/test/python/apache/thermos/common/test_pathspec.py 
> 3437b196d33d7c2ff6ba292ff99b6881954e7ecb 
> 
> Diff: https://reviews.apache.org/r/30704/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to