> On Feb. 6, 2015, 3:11 p.m., Brian Wickman wrote:
> >

In practice I've found that this helps catch issues sooner than later, as we'll 
see missing dependencies from the main target (which I've done before).

Happy to move away if you disagree though (I know it's a tradeoff)


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71520
-----------------------------------------------------------


On Feb. 6, 2015, 2 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27182/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 2 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a test for the thermos resource module
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/monitoring/monitor.py 
> 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 33d6bba43aff6d62b2646491f004475c27ed99db 
>   src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27182/diff/
> 
> 
> Testing
> -------
> 
> [tw-mbp-jsmith incubator-aurora (yasumoto/thermos_test)]$ ./pants test.pytest 
> ./src/test/python/apache/thermos/monitoring:test_resource
> 
> 21:15:56 00:00 [main]
>                (To run a reporting server: ./pants server)
> 21:15:56 00:00   [bootstrap]
> 21:15:57 00:01   [setup]
> 21:15:57 00:01     [parse]
>                Executing tasks in goals: bootstrap -> imports -> gen -> 
> check-exclusives -> resolve -> compile -> resources -> test
> 21:15:57 00:01   [bootstrap]
> 21:15:57 00:01     [bootstrap-jvm-tools]
> 21:15:57 00:01   [imports]
> 21:15:57 00:01     [ivy-imports]
> 21:15:57 00:01   [gen]
> 21:15:57 00:01     [thrift]
> 21:15:57 00:01     [scrooge]
> 21:15:57 00:01     [protoc]
> 21:15:57 00:01     [antlr]
> 21:15:57 00:01     [ragel]
> 21:15:57 00:01     [jaxb]
> 21:15:57 00:01     [wire]
> 21:15:57 00:01     [aapt]
> 21:15:57 00:01   [check-exclusives]
> 21:15:57 00:01     [check-exclusives]
> 21:15:57 00:01   [resolve]
> 21:15:57 00:01     [ivy]
> 21:15:57 00:01   [compile]
> 21:15:57 00:01     [jvm]
> 21:15:57 00:01       [jvm-compilers]
> 21:15:57 00:01   [resources]
> 21:15:57 00:01     [prepare]
> 21:15:57 00:01   [test]
> 21:15:57 00:01     [run_prep_command]
> 21:15:57 00:01     [pytest]
> 21:15:57 00:01       [run]
>                      ============== test session starts ===============
>                      platform darwin -- Python 2.7.6 -- py-1.4.26 -- 
> pytest-2.6.4
>                      plugins: cov, timeout
>                      collected 5 items 
>                      
>                      
> src/test/python/apache/thermos/monitoring/test_resource.py .....
>                      
>                      ============ 5 passed in 0.18 seconds ============
>                      
> 21:16:04 00:08     [junit]
> 21:16:04 00:08     [specs]
>                SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to