-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30768/#review71577
-----------------------------------------------------------


I would love to see something in the top-level integration test that would have 
caught this.  Lacking anything like selenium, we could take on some coupling to 
low-level details and construct/curl the observer URL:

    # Find the task ID.
    task_id=$(aurora_admin query --states=RUNNING -l '%taskId%'  devcluster 
www-data hello)

    # Get the HTTP response code from the observer.
    check_url_live http://localhost:1338/task/$task_id

Do you think that's reasonable?

- Bill Farner


On Feb. 8, 2015, 2:06 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30768/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 2:06 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1115
>     https://issues.apache.org/jira/browse/AURORA-1115
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch modifies TaskPath to reject None values.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7b346e253677ee9b42c57782f7f67ff63b6a0083 
>   src/main/python/apache/thermos/common/path.py 
> 9e617051f16f4270b3958f48e0cc43706d245eec 
>   
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
>  PRE-CREATION 
>   src/test/python/apache/thermos/common/test_pathspec.py 
> 3437b196d33d7c2ff6ba292ff99b6881954e7ecb 
> 
> Diff: https://reviews.apache.org/r/30768/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos::
> ./pants test src/test/python/apache/aurora/executor::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to