----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30804/#review71691 -----------------------------------------------------------
Ship it! Master (dcae1e8) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 9, 2015, 7:57 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30804/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 7:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > The startJobUpdate RPC test coverage got broken in > 9fe6d5408d4aed113a239f22fa5c43aa4f9ae338 as all settings tests > short-circuited at `isIsService()` validation. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 2b5383f3c56927bc42ab47c0a5c7c4b1d41af6dd > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > c6fe218c709c73dbd4c3aeeb94e211ee6cdf9a0d > > Diff: https://reviews.apache.org/r/30804/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
