-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/
-----------------------------------------------------------
(Updated Feb. 9, 2015, 8:22 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
-------
Adds entry point tests for gc/thermos executors, since I got some of the import
wiring wrong:
vagrant@192:/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/latest$
cat stderr
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0209 19:16:58.301468 22286 fetcher.cpp:76] Fetching URI
'/home/vagrant/aurora/dist/gc_executor.pex'
I0209 19:16:58.301730 22286 fetcher.cpp:179] Copying resource from
'/home/vagrant/aurora/dist/gc_executor.pex' to
'/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/6f1f2749-66a9-41e7-bb68-5e31c08cac6d'
Traceback (most recent call last):
File
"/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/6f1f2749-66a9-41e7-bb68-5e31c08cac6d/gc_executor.pex/.bootstrap/_pex/pex.py",
line 272, in execute
self.execute_entry(entry_point, args)
File
"/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/6f1f2749-66a9-41e7-bb68-5e31c08cac6d/gc_executor.pex/.bootstrap/_pex/pex.py",
line 320, in execute_entry
runner(entry_point)
File
"/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/6f1f2749-66a9-41e7-bb68-5e31c08cac6d/gc_executor.pex/.bootstrap/_pex/pex.py",
line 342, in execute_pkg_resources
runner = entry.load(require=False) # trust that the environment is sane
File
"/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/6f1f2749-66a9-41e7-bb68-5e31c08cac6d/gc_executor.pex/.bootstrap/pkg_resources.py",
line 2048, in load
entry = __import__(self.module_name, globals(),globals(), ['__name__'])
File
"/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/6f1f2749-66a9-41e7-bb68-5e31c08cac6d/gc_executor.pex/apache/aurora/executor/bin/gc_executor_main.py",
line 27, in <module>
ImportError: No module named executor_detector
vagrant@192:/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-0000/executors/aurora.gc/runs/latest$
Bugs: AURORA-1025
https://issues.apache.org/jira/browse/AURORA-1025
Repository: aurora
Description
-------
This makes the GC executor detect checkpoint roots via the PathDetector
interface. This paves the way to detecting checkpoint roots both from
/var/run/thermos and from /var/lib/mesos/**
Diffs (updated)
-----
src/main/python/apache/aurora/executor/bin/BUILD
1fa1e9e839bf28093b4e9ded403a761cf4bf5f44
src/main/python/apache/aurora/executor/bin/gc_executor_main.py
b903bcb3630a8a8d50a2008bfae532b2eb947356
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
0752d50015b2ff936f079c4a9f2777172dc00a93
src/main/python/apache/aurora/executor/gc_executor.py
43b415bc6c5177be24ec036cc32ae7cbd87fc70f
src/main/python/apache/thermos/bin/thermos.py
161bbdbc4de95c82e2b596e77b0eac7b920eae66
src/main/python/apache/thermos/monitoring/garbage.py
69bf8e4c2e2e5f85f6b822fbe45f828d61814d7f
src/test/python/apache/aurora/executor/bin/BUILD PRE-CREATION
src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py
PRE-CREATION
src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py
PRE-CREATION
src/test/python/apache/aurora/executor/test_gc_executor.py
b1bbc89a822302d8ea12324eb767631326639ebb
Diff: https://reviews.apache.org/r/30749/diff/
Testing
-------
./pants test.pytest --no-fast src/main/python::
Thanks,
Brian Wickman
