----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72249 -----------------------------------------------------------
src/test/python/apache/aurora/client/cli/util.py <https://reviews.apache.org/r/30950/#comment118308> Why don't you just use the imported values instead of declaring them here again? - Zameer Manji On Feb. 12, 2015, 1:59 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30950/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 1:59 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: AURORA-1120 > https://issues.apache.org/jira/browse/AURORA-1120 > > > Repository: aurora > > > Description > ------- > > Add the option to make a non-hooked API. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py > f8b289938201da1edd7d6dde2c65124b80b58adb > src/main/python/apache/aurora/client/factory.py > 85a1398106a575c1b7759b904b32db6b07da7c1b > src/test/python/apache/aurora/client/BUILD > c55adfe9825b77f418e41fa9a4ba43926bd991ed > src/test/python/apache/aurora/client/cli/BUILD > 7319962b285b449b275196eb0c4033e963579d8e > src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION > src/test/python/apache/aurora/client/cli/util.py > 12360c64a6c6f46d5b96f604c002b59d0f1a9b0e > src/test/python/apache/aurora/client/test_factory.py PRE-CREATION > src/test/python/apache/aurora/client/util.py PRE-CREATION > > Diff: https://reviews.apache.org/r/30950/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python/apache/aurora/client:: > > > Thanks, > > Joshua Cohen > >
