----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/ -----------------------------------------------------------
(Updated Feb. 12, 2015, 4:33 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes ------- rebase Repository: aurora Description ------- Extract ReadOnlyScheduler to its own implementation class and delegate from the existing SchedulerThriftInterface to it. This enables serving ReadOnlyScheduler from a separate HTTP endpoint (e.g. an unauthenticated one). This is almost a pure tool-driven refactor-rename change. Also renames Util to Responses for improved ergonomics. To boost confidence in this change tests have been left in place. I will follow-up with a subsequent review to split out ReadOnlySchedulerImplTest. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 53ea03bac3784baebc630ad1ce235d263985cafe src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7014d598d41f007b0dee0b2db1aa2d4cdd592be6 src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 7b28eb87767d7cd19e9365e3287f3e943d87dea5 src/main/java/org/apache/aurora/scheduler/thrift/Util.java 55242d18e08ea5cb6dd297bd7f18744d952580b3 src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java e176a0df3141dcb088e05203cca4de3f0d3feea7 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java cad63c77e8144bb64c6b2acaf1b9199be13e4145 src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java 5e6577d64b1037c69c3a952008240dcafe3b9f94 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 491aa34d76a6f3fe91188bbc73a2cc7464f3644b Diff: https://reviews.apache.org/r/30957/diff/ Testing ------- ./gradlew -Pq build Thanks, Kevin Sweeney