-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31022/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
-------

Fixing aurora beta-update status command.

Also, refactored tests a bit and fixed a related issue with aurora `beta-update 
list` formatting.


Diffs
-----

  src/main/python/apache/aurora/client/base.py 
480728d4c3b574897ea0897f2cc6467af3ba08e6 
  src/main/python/apache/aurora/client/cli/update.py 
6e7e9c64c59ab9a48d016d5bc1e870340f8d5d7e 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
0114e200be4d5fb07db855085fce5bc3bc2dded5 
  src/test/python/apache/aurora/client/test_base.py 
bc4424b5870ae0c351323bd43d5b38b888f548d5 

Diff: https://reviews.apache.org/r/31022/diff/


Testing
-------

./pants test.pytest --no-fast src/test/python:all

Before:
```
$ aurora beta-update status devcluster/www-data/prod/hello
 INFO] 
Command failure:
Fatal error running command:
Traceback (most recent call last):
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 312, 
in _execute
    result = noun.execute(context)
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 390, 
in execute
    return self.verbs[context.options.verb].execute(context)
  File "/usr/local/bin/aurora/apache/aurora/client/cli/update.py", line 252, in 
execute
    context.log_response_and_raise(response)
  File "/usr/local/bin/aurora/apache/aurora/client/cli/context.py", line 135, 
in log_response_and_raise
    self.print_err("\t%s" % combine_messages(resp))
  File "/usr/local/bin/aurora/apache/aurora/client/base.py", line 50, in 
combine_messages
    return ', '.join([d.message for d in (response.details or [])])
TypeError: sequence item 0: expected string, NoneType found
```

After:
```
$ aurora beta-update status devcluster/www-data/prod/hello
 INFO] 
No updates found for job devcluster/www-data/prod/hello
 INFO] Command terminated with error code 6
```


Thanks,

Maxim Khutornenko

Reply via email to