-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31104/#review72865
-----------------------------------------------------------
Master (4b43305) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.sla
..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate
..... SUCCESS
src.test.python.apache.aurora.client.cli.task
..... SUCCESS
src.test.python.apache.aurora.client.cli.update
..... SUCCESS
src.test.python.apache.aurora.client.cli.version
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.factory
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.config.test_base
..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
..... SUCCESS
src.test.python.apache.aurora.config.test_loader
..... SUCCESS
src.test.python.apache.aurora.config.test_thrift
..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer
..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout
..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
..... FAILURE
src.test.python.apache.aurora.executor.common.path_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.aurora.executor.executor_base
..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars
..... SUCCESS
src.test.python.apache.aurora.executor.status_manager
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 17, 2015, 6:22 a.m., Moses Nakamura wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31104/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 6:22 a.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is the first step in changing TASK_RUNNING to mean that the application
> is alive and responding to health checks (if the task is configured to
> support health checks). This review is just to get feedback, I can't do this
> review in parts because the scheduler must be changed in lockstep with the
> executor, or everything will break.
>
> I don't know if this is the right approach, could you give me some high level
> advice? I'm also not sure who to add to this review.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/aurora_executor.py
> 9c0282392dbb9cca308baf47adc1750c1f5cacc6
> src/main/python/apache/aurora/executor/common/announcer.py
> dda76f018f472d7d8228459eb89f4c5daf9df26d
> src/main/python/apache/aurora/executor/common/health_checker.py
> 60676ba0fbd8a218fe4309f07de28e2c66d54530
> src/main/python/apache/aurora/executor/common/resource_manager.py
> 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/common/status_checker.py
> 624921d68199df098ea51ee8a10815403bf58984
> src/test/python/apache/aurora/executor/common/test_announcer.py
> 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/common/test_health_checker.py
> def249c2509a28f7145380f250f79202b653dc83
>
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
> 8f288f6115ab52265dfaffffda3f41d81271c55a
>
> Diff: https://reviews.apache.org/r/31104/diff/
>
>
> Testing
> -------
>
> This hangs after I call is_health_checks_enabled, and I don't know why. My
> suspicion is that I'm throwing an exception and cratering the task executor,
> but I don't know how to tell. How do I get it to print? I'm running it with:
>
> ./pants test src/test/python/apache/aurora/executor::
>
>
> Thanks,
>
> Moses Nakamura
>
>
