-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/#review73043
-----------------------------------------------------------



api/src/main/thrift/org/apache/aurora/gen/storage.thrift
<https://reviews.apache.org/r/31170/#comment119207>

    Do we really need a deprecation cycle here given the beta status of the 
updater? The interface instability is something expected from an API in beta 
status. Keeping things around will just hurt our iteration speed unnecessarily.
    
    E.g. guava @Beta annotation says:
    
    "Signifies that a public API (public class, method or field) is subject to 
incompatible changes, or even removal, in a future release. An API bearing this 
annotation is exempt from any compatibility guarantees made by its containing 
library." 
    
    
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/annotations/Beta.html


- Maxim Khutornenko


On Feb. 19, 2015, 12:19 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31170/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 12:19 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1093
>     https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> In an effort to keep the diffs manageable, phase 2 started by changing the 
> signatures of `JobUpdateStore.Mutable` (read APIs still use just the update 
> ID string).  This change is mostly mechanical, with a few noteworthy 
> exceptions:
> 
> - SaveJobUpdateEvent and SaveJobInstanceUpdateEvent now have a JobUpdateKey 
> field, so LogStorage dual reads and writes
> - JobUpdateStore.fetchUpdateKey was added to facilitate the above
> 
> If we are happy with this diff, i will create relevant 0.9.0 tickets to 
> remove the old SaveJob[Instance]UpdateEvent fields.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> 3798797bbd4a7f26b78bfd63e2d275cbec60cab3 
>   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
> 7a349bb36991851c6936ee990b529cc8c6fbc3d7 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 934b92021d08ca23d95888683e9527ce37a8690a 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 3ca150c3088d99f331ca8e84a235f25e5eb26e17 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 629a39b824a0f606f7697d637426510b6a0a41cb 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
> 34c4ab5adddbb62f117497b8007bc9b70ddd4490 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.java
>  4fb33bd6a68d1f0c7b113558fbdcce328e51dbdb 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> ba1672f06425db9477d52a91b36e0b0a1756430a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> ea33037d86f30f0787136f34dad34b88eceb0a4d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> 2d275997edb57d3474a33ea7cf924e2500334234 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2d21a976379631d11a498e7fcfd7cb6b800f3c15 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> d0def6ee0ad31f9dbb47fe2052aaf4ec3540b1fa 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  f39d8768e7a83089f32b036ac072c50c3e0a66bd 
>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  1cd693a07dcc1fb3136a64e49f9481078fec45a1 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  156cbc49d8492c5a0209deae11c7be77ab2e0048 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 0a5cc51967f756411ca1489d81872f863c045b6b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  8fc3cb865fbcd467db91f4cb828d381a02ba7595 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  9393ad7a3e09865ae0c88b983c577a73e6782016 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  06c8faa9de4d0ac8389dbf07d4e81934b503761b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> a15c409d9b9aafd55372b5f6d7e775ebbf894ac1 
> 
> Diff: https://reviews.apache.org/r/31170/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to