-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31235/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
-------

Removing job store "proxy" methods from CronJobManager and dropping job manager 
concept from the storage. The job manager is long gone but we still carry 
around the job manager ID.

Despite the diff's size the changes are mostly mechanical: replacing 
CronJobManager occurrences with direct job store access.


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
3798797bbd4a7f26b78bfd63e2d275cbec60cab3 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
b8830d187de27533307a8a2e9be6385f5d3e2289 
  src/main/java/org/apache/aurora/scheduler/cron/CronJobManager.java 
fc6e4432d64e625a583d8c8a130d99e066fd232c 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
efea7ad9f6efc99b600d071c3c20063b6bc4b211 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
c5cb8cae43c86ae2378a0bef7688d400aa188e57 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 
64d9486fade3b03b8db936fe60790ea0858212a9 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
063170ac869dafc161c73f735b33f4cbe8e03ab6 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
934b92021d08ca23d95888683e9527ce37a8690a 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
3ca150c3088d99f331ca8e84a235f25e5eb26e17 
  src/main/java/org/apache/aurora/scheduler/storage/JobStore.java 
ad0d67a27628f46dedda2ae4e0e61025dff1e1fd 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
83a59ce5d5b2754b1d31354280eca31922d73cdd 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
52377bca8060720dc4bec884c911182c3e77bc52 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
ba1672f06425db9477d52a91b36e0b0a1756430a 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
ea33037d86f30f0787136f34dad34b88eceb0a4d 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
2d275997edb57d3474a33ea7cf924e2500334234 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java 
c24a32e57b34a1fc41681fda9bdb4de38ed8896b 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
2d21a976379631d11a498e7fcfd7cb6b800f3c15 
  src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
97ecb742d6e0418890f875394ded8d9fdae2b1c2 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
c99135ab9c55a42ab51f18cc5ea127b498f0721f 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
915d7c8294b3d8262021da1c30324f55d8413ff9 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
 701536fff8948ef233523e114e45043992175891 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b0772f73f1a21da5828660bfd7d2b1f6b15cbf74 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
493150b062eddf2581a048a9e13826205b8f2c15 
  
src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 
15fc4404fa2ace4391e4ddc7153c848bc91d43df 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
0a5cc51967f756411ca1489d81872f863c045b6b 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 8fc3cb865fbcd467db91f4cb828d381a02ba7595 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemJobStoreTest.java 
2e0c4151f58a28b695c13a392bae126857d4c4b6 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 06c8faa9de4d0ac8389dbf07d4e81934b503761b 

Diff: https://reviews.apache.org/r/31235/diff/


Testing
-------

./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Maxim Khutornenko

Reply via email to