-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73380
-----------------------------------------------------------
Master (e5de618) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.update
..... SUCCESS
src.test.python.apache.aurora.client.cli.version
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.factory
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.config.test_base
..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
..... SUCCESS
src.test.python.apache.aurora.config.test_loader
..... SUCCESS
src.test.python.apache.aurora.config.test_thrift
..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer
..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout
..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager
..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.aurora.executor.executor_base
..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars
..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor
..... FAILURE
src.test.python.apache.aurora.executor.status_manager
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 21, 2015, 1:09 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31251/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2015, 1:09 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix swallowed exceptions in health check test. One of the health checkers
> was raising uncaught exceptions on a separate thread. The Python interpreter
> on CI *might* behave slightly differently and fail here. To be honest I've
> not been able to reproduce the CI behavior, so hopefully buildbot can chime
> in here.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py
> 0d3365d395c65793b90ce96f277b7f4e4b1dcb99
> src/test/python/apache/aurora/executor/common/test_health_checker.py
> 4e09d309d402cf678c69d033e5219e9c8e4ccaaa
>
> Diff: https://reviews.apache.org/r/31251/diff/
>
>
> Testing
> -------
>
> Ran the following about 100 times:
>
> THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs'
> src/test/python/apache/aurora/executor/common:health_checker
>
>
> Thanks,
>
> Brian Wickman
>
>
