> On Feb. 23, 2015, 6:22 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, > > lines 199-201 > > <https://reviews.apache.org/r/31248/diff/5/?file=871734#file871734line199> > > > > Well, I think this is actually worse than it was. In case there is no > > StringBuilder concatenation active in JVM, this is still producing > > unnecessary string objects. However, in the opposite case, there will be > > muiltiple StringBuilder objects and heap churn may be even worse. > > > > Don't want to block review on this anymore but please, convert > > everything to a single StringBuilder without concatenation or revert back > > to concatenation to hopefully take advantage of an auto generated > > StringBuilder.
Sorry, that was hasty, and i agree an odd use of StringBuilder. I will update to remove concatenation. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31248/#review73608 ----------------------------------------------------------- On Feb. 21, 2015, 6:33 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31248/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 6:33 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1028 > https://issues.apache.org/jira/browse/AURORA-1028 > > > Repository: aurora > > > Description > ------- > > Export stats for source and reason for LOST tasks, and status delivery > latency. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 1d8f0128732756db74576ee669f6a2718fecc105 > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > ffc30bb548706df7bec9e1502242890e9b5eb942 > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java > 59ad9e65589c421cefb76f265446fa2885e6198c > src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > d02c6b32841d5d39c5780e7a044079a38729effb > src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31248/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
