----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31289/#review73674 -----------------------------------------------------------
Ship it! Thanks! Tested this patch by doing some build commands on an existing vagrant machine, and creating a new one from scratch. - Bill Farner On Feb. 23, 2015, 8:02 p.m., Thorhallur Sverrisson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31289/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 8:02 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1138 > https://issues.apache.org/jira/browse/AURORA-1138 > > > Repository: aurora > > > Description > ------- > > To make sure the vagrant system is up and running successfully > we need to fail the provisioning steps when errors strike. > > Bash -e flag tells bash to exit on any non-zero exit from any > command (with excpetions), giving us the early exit needed. > > To ignore errors add '|| true' after the command to ignore > failures from. > > After the provisioning steps complete the aurora-scheduler does not start due > to > > `Could not find or load main class > org.apache.aurora.scheduler.app.SchedulerMain` > > I'm trying to figure out why, but gradle is new to me so I'm not sure why it > is not being built/included in the .jar files. > > > Diffs > ----- > > examples/vagrant/aurorabuild.sh cb6fb1a0259c03ca11c4f355774a19eda985e097 > examples/vagrant/provision-dev-cluster.sh > 042298408944d60e286aad3947f51fe4a6af7c8c > > Diff: https://reviews.apache.org/r/31289/diff/ > > > Testing > ------- > > vagrant destroy > vagrant up > > > Thanks, > > Thorhallur Sverrisson > >
