> On Feb. 24, 2015, 11:35 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/async/OfferManager.java, line 317
> > <https://reviews.apache.org/r/30891/diff/7/?file=873086#file873086line317>
> >
> > Same as above - no need to hold the intrinsic lock while logging here.
>
> Maxim Khutornenko wrote:
> Same here.
my shipit stands but you can use the same lock with a
```java
synchronized (this) {
. // logic
}
```
construct
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review72448
-----------------------------------------------------------
On Feb. 24, 2015, 1:30 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30891/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 1:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-909
> https://issues.apache.org/jira/browse/AURORA-909
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Offer filtering for static vetoes. Part 3 of 4: Filtering out statically
> banned offers.
>
> Will not apply cleanly: diffed with https://reviews.apache.org/r/30890 as a
> parent.
>
> Original RB: https://reviews.apache.org/r/28617/
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/OfferManager.java
> b241d7b22c3d1ceca127b2671eb608ae41283bf3
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java
> 21ea7d2b9d2f8c76367d7ae985270402bb51ea26
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
> 5a0f7ddb7e8fa6869cbb0fdfd07c6881780c6917
> src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java
> 7ee2bb9bec6c59ba67b65d5b1229c64aca1277ff
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java
> 9eef52a333e09454e8fd0026371c7e64472a883d
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
> b6d4d8e771c7d16a46e43c7d5c427b911f8b661d
>
> Diff: https://reviews.apache.org/r/30891/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
