-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31389/#review73954
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Feb. 25, 2015, 12:01 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31389/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 12:01 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1055
>     https://issues.apache.org/jira/browse/AURORA-1055
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove LiveClusterState, make CachedClusterState (now ClusterStateImpl) 
> default.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 0351b10cbfff76f07eec15c5ed1af7bb5f39a8ce 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java
>  2831103457184d2049684c1c519b6bbb3b5b3e62 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java
>  38cb17371735d959c14fc7bf9fc25b8eb814fdfe 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
>  2030a9413035e1ad7db52b13957ed074b211d558 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterStateTest.java
>  7cc04dd4ea214f7e9923be51b467a2564fec18bb 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java
>  763f8b5f3aaaa1349f291c0ede7b5d3292f6ca5b 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  83cf118c9e1d32b0de511754b4aeadd8aed33e49 
> 
> Diff: https://reviews.apache.org/r/31389/diff/
> 
> 
> Testing
> -------
> 
> Standard tests.  I removed a test case `testIgnoresThrottledTasks`, which was 
> actually testing LiveClusterState behavior.  That test case was redundant to 
> unit testing in `ClusterStateImpl`.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to