-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31406/#review74016
-----------------------------------------------------------
Master (4d5885b) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.cron
..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect
..... SUCCESS
src.test.python.apache.aurora.client.cli.job
..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins
..... SUCCESS
src.test.python.apache.aurora.client.cli.quota
..... SUCCESS
src.test.python.apache.aurora.client.cli.sla
..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate
..... SUCCESS
src.test.python.apache.aurora.client.cli.task
..... SUCCESS
src.test.python.apache.aurora.client.cli.update
..... SUCCESS
src.test.python.apache.aurora.client.cli.version
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.factory
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.config.test_base
..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
..... SUCCESS
src.test.python.apache.aurora.config.test_loader
..... SUCCESS
src.test.python.apache.aurora.config.test_thrift
..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.aurora.executor.executor_base
..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars
..... SUCCESS
src.test.python.apache.aurora.executor.status_manager
..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
..... FAILURE
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Feb. 25, 2015, 10:57 a.m., Florian Pfeiffer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31406/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 10:57 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-321
> https://issues.apache.org/jira/browse/AURORA-321
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding the possiblity to define the port where the health checker should run
> on
>
> Note: The added mesos_task to the task runner seems to make the old task
> object superfluous. I wasn't sure if I could remove the task object that
> easily without breaking stuff, though.
> If we will go the way, that we're separating graceful teardown from
> healthcheck, we probably need the mesos_task object as well
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py
> a87524a8b3ad5aa0e337e0a0028cecb85865b4e6
> src/main/python/apache/aurora/executor/common/health_checker.py
> 60676ba0fbd8a218fe4309f07de28e2c66d54530
> src/main/python/apache/aurora/executor/thermos_task_runner.py
> 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
>
> Diff: https://reviews.apache.org/r/31406/diff/
>
>
> Testing
> -------
>
> test_end_to_end.sh
>
>
> Thanks,
>
> Florian Pfeiffer
>
>
