> On Feb. 25, 2015, 10:54 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java,
> >  line 92
> > <https://reviews.apache.org/r/31445/diff/1/?file=876532#file876532line92>
> >
> >     I think some JavaDoc explaining which stats are exported would be nice. 
> > This would enable an operator/user to grep the source to see which code is 
> > responsible for a stat.

Overall -1 to that as there's nothing preventing drift.  I think it's generally 
safe to assume that operators understand that strings may be concatenated and 
grepping for specific parts may be required.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31445/#review74122
-----------------------------------------------------------


On Feb. 25, 2015, 10:45 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31445/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-524
>     https://issues.apache.org/jira/browse/AURORA-524
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Expose more details about the tasks the preemptor is working for.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> 42af883721e4e5c0ae23ff65a5fb7dc285e48faa 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  44cd8f79493f0f247cd876ef78b30b4f813314c4 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 
> 768e78424268513742ecea22b2f5395dcb46da8c 
> 
> Diff: https://reviews.apache.org/r/31445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to