-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 10:43 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
-------

Holy smokes, there was some test coverage.  Fix the tests.


Bugs: AURORA-1026
    https://issues.apache.org/jira/browse/AURORA-1026


Repository: aurora


Description
-------

This creates a new abstraction, the ObserverTaskDetector, which is responsible 
for managing state transitions for tasks for the observer.  Adds some tests and 
better debug logging.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/common/BUILD 
8cef41d04aff9edc7da7053e05341274a9bd0834 
  src/main/python/apache/aurora/executor/common/resource_manager.py 
08e02e41b581f275f070228bb23c4cf2a0489f9a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/common/path.py 
846f507e2e097fc04fe0098a7250b40fefcfc6e2 
  src/main/python/apache/thermos/monitoring/disk.py 
175ed3af6515e6107e297d91d4e30cbb3034faf7 
  src/main/python/apache/thermos/monitoring/monitor.py 
11423bc1764c8380d8de4ad095c1e2748ebb78f8 
  src/main/python/apache/thermos/monitoring/resource.py 
b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 
  src/main/python/apache/thermos/observer/BUILD 
ee65f3a46e1d339620e76cadae92c6678fc3510f 
  src/main/python/apache/thermos/observer/bin/BUILD 
15a03f74f204f58856f0843b9db05e83b89d1138 
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
effa8c19f963bf2792497f4a06049214ae30dfa5 
  src/main/python/apache/thermos/observer/detector.py PRE-CREATION 
  src/main/python/apache/thermos/observer/http/file_browser.py 
87ef9c8a29689c78a5e39a46cc53e4675e36a381 
  src/main/python/apache/thermos/observer/observed_task.py 
f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 
  src/main/python/apache/thermos/observer/task_observer.py 
cd528dcca3f5a330359cf38005f3a1a0329a4886 
  src/test/python/apache/aurora/executor/BUILD 
2ee9b1233e9db47455ddccccffbc48691d379222 
  src/test/python/apache/aurora/executor/common/BUILD 
7b73f693d161cfd205435e4acb398f553b92389f 
  
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
 8f288f6115ab52265dfaffffda3f41d81271c55a 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/core/test_staged_kill.py 
faa23ae6afcaa443d23c65e5e027902961a0e52b 
  src/test/python/apache/thermos/monitoring/BUILD 
9c267775080e0bde08ff4e9b01862c6bee187634 
  src/test/python/apache/thermos/monitoring/test_resource.py 
52d813946379bdc70c40ad079c74b54f60bd4b41 
  src/test/python/apache/thermos/observer/BUILD PRE-CREATION 
  src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31451/diff/


Testing
-------

Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::


Thanks,

Brian Wickman

Reply via email to