-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review74880
-----------------------------------------------------------



debian/aurora-executor.thermos.default
<https://reviews.apache.org/r/31101/#comment121698>

    needs license header



debian/aurora-executor.thermos.init
<https://reviews.apache.org/r/31101/#comment121697>

    Needs license header



debian/aurora-scheduler.default
<https://reviews.apache.org/r/31101/#comment121701>

    needs license header



debian/aurora-scheduler.init
<https://reviews.apache.org/r/31101/#comment121700>

    needs license header



debian/aurora-scheduler.postinst
<https://reviews.apache.org/r/31101/#comment121699>

    needs license header



debian/embed-runner-in-executor.py
<https://reviews.apache.org/r/31101/#comment121702>

    if we keep this file then it needs license header added



debian/rules
<https://reviews.apache.org/r/31101/#comment121703>

    needs license header


Bunch of files missing license headers as notes, but overall looks good. Would 
be nice to not have to put this at the top level, as wfarner pointed out also, 
but then would have to deal with symlinking and juggling to make it work (we 
did this in thrift before moving to the top level for ease). Would be good to 
wrap creation into a task that executed dch and dpkg commands all in one call

- Jake Farrell


On Feb. 17, 2015, 12:20 a.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31101/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 12:20 a.m.)
> 
> 
> Review request for Aurora and Jake Farrell.
> 
> 
> Bugs: AURORA-951
>     https://issues.apache.org/jira/browse/AURORA-951
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Native Debian packaging for Aurora
> 
> This uses Debian package dependencies to install gradle and thrift-compiler.  
> Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own 
> package easily enough using https://github.com/benley/gradle-packaging
> 
> 
> Diffs
> -----
> 
>   debian/aurora-doc.docs PRE-CREATION 
>   debian/aurora-doc.examples PRE-CREATION 
>   debian/aurora-executor.dirs PRE-CREATION 
>   debian/aurora-executor.install PRE-CREATION 
>   debian/aurora-executor.links PRE-CREATION 
>   debian/aurora-executor.thermos.default PRE-CREATION 
>   debian/aurora-executor.thermos.init PRE-CREATION 
>   debian/aurora-executor.thermos.upstart PRE-CREATION 
>   debian/aurora-scheduler.default PRE-CREATION 
>   debian/aurora-scheduler.init PRE-CREATION 
>   debian/aurora-scheduler.install PRE-CREATION 
>   debian/aurora-scheduler.links PRE-CREATION 
>   debian/aurora-scheduler.postinst PRE-CREATION 
>   debian/aurora-scheduler.upstart PRE-CREATION 
>   debian/aurora-tools.install PRE-CREATION 
>   debian/aurora-tools.links PRE-CREATION 
>   debian/changelog PRE-CREATION 
>   debian/clusters.json PRE-CREATION 
>   debian/compat PRE-CREATION 
>   debian/control PRE-CREATION 
>   debian/copyright PRE-CREATION 
>   debian/embed-runner-in-executor.py PRE-CREATION 
>   debian/pants.ini PRE-CREATION 
>   debian/rules PRE-CREATION 
>   debian/source/format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31101/diff/
> 
> 
> Testing
> -------
> 
> Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
> pbuilder. Have been using debs built from this branch on a testing cluster 
> for a few months now.
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>

Reply via email to