-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review75096
-----------------------------------------------------------

Ship it!


Nice!


src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java
<https://reviews.apache.org/r/31652/#comment122032>

    s/taskId/groupKey/



src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java
<https://reviews.apache.org/r/31652/#comment122034>

    Should this cache be renamed?


- Bill Farner


On March 3, 2015, 12:58 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31652/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 12:58 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-911
>     https://issues.apache.org/jira/browse/AURORA-911
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
> storing veto reasons by TaskGroupKey in NearestFit.
> 
> Depends on https://reviews.apache.org/r/31646/.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> c103472b9404df1c690b3a6019d64d42e15f2fed 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 53582c63ddee23e643bd4654cad2bef75dfba36d 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 13520eb5846022ed0b43b402096fe02565103aa9 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  ab7817f929bbcc96a6046043ea17921a388fdb9f 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> 78a236c0f9074692b67ce18e6e03f18fe4529e02 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  ce5a62650cebab9a53743460f5a5119f62efec1c 
> 
> Diff: https://reviews.apache.org/r/31652/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to