> On March 3, 2015, 11:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 302 > > <https://reviews.apache.org/r/31710/diff/1/?file=883800#file883800line302> > > > > You may want to extract an internal method to do this, e.g.: > > ``` > > def timestamp(time_msec): > > return time.ctime(time_msec / 1000) > > ```
Done. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/#review75089 ----------------------------------------------------------- On March 3, 2015, 11:44 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31710/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 11:44 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1165 and AURORA-1166 > https://issues.apache.org/jira/browse/AURORA-1165 > https://issues.apache.org/jira/browse/AURORA-1166 > > > Repository: aurora > > > Description > ------- > > Discovered these while working on AURORA-1157 > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/update.py > ee8146be0cb6e3f3139a5491c883864950f245bd > src/test/python/apache/aurora/client/cli/test_supdate.py > 1173650998d397a68a7fabf38201fb9feebf2977 > > Diff: https://reviews.apache.org/r/31710/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
