> On March 4, 2015, 2:46 a.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 145
> > <https://reviews.apache.org/r/31716/diff/1/?file=884042#file884042line145>
> >
> >     kill newline

This was to follow the convention we have for continued statements in java, e.g.

```
if (longStatement &&
    otherLongStatement) {
    
  // beginning of body   
}
```

However, a refactor to satisfy pause/resume obviated this.


> On March 4, 2015, 2:46 a.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 159
> > <https://reviews.apache.org/r/31716/diff/1/?file=884042#file884042line159>
> >
> >     Should it also include a pause/resume cycle?

Done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31716/#review75141
-----------------------------------------------------------


On March 4, 2015, 1:21 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31716/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 1:21 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1157
>     https://issues.apache.org/jira/browse/AURORA-1157
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an end-to-end test for scheduler-driven job updates.
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 6a75528aeb62c119e4f8ab602d0e2081dc07fe49 
> 
> Diff: https://reviews.apache.org/r/31716/diff/
> 
> 
> Testing
> -------
> 
> Ran end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to