> On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, lines 123-127
> > <https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123>
> >
> >     Mind sorting them alphabetically?
> 
> Bill Farner wrote:
>     Done.

Spoke too soon here - ordering is important with these, and this pointed out 
that my new field should have been named `MESSAGE_OPTION` (as it's an option 
rather than an argument).  I've sorted the options, which are order-agnostic.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76243
-----------------------------------------------------------


On March 12, 2015, 1:27 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 1:27 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1077
>     https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> More plumbing.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 4025781963a61821d111e6347ae02d27459fd8cd 
>   src/main/python/apache/aurora/client/cli/update.py 
> 37cc49880eab2ac0879945714634a4938b603aae 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 60a5aad7c3a7388154654673a6669c93be716635 
>   src/test/python/apache/aurora/api_util.py 
> 70599555c8b13073e51adee31662df74afe67edb 
>   src/test/python/apache/aurora/client/api/test_api.py 
> d211fb975db01e72a88312c28078e06cb622d83c 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 370a46b46d8fe9499468e0792f181e79e8042b61 
> 
> Diff: https://reviews.apache.org/r/31966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to