> On March 13, 2015, 2:30 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, 
> > line 255
> > <https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line255>
> >
> >     This is a pretty weird log entry to have.  Can it be done in the client 
> > instead?
> 
> Maxim Khutornenko wrote:
>     Client already has logs but that's not enough to reconstruct the behavior 
> when maintenance stalls. We need to see both sides of the story to properly 
> troubleshoot host draining issues.
> 
> Bill Farner wrote:
>     This one i still don't follow - AFAICT it's literally printing the 
> response handed directly to the client, which is the only caller if i'm 
> reading correctly.

Having it only on the client hampers investigation when client logs are missing 
or incomplete. This logging completes the scheduler view of the maintenance 
story, which can be reconstructed any time we have a question and the client 
logs a long gone.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32014/#review76332
-----------------------------------------------------------


On March 13, 2015, 1:23 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32014/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 1:23 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also added missing test coverage.
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 06e130fae6bdc43b5e8aff182a530eac65acca53 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> b6f642e319b790544bc538098e7cb78b1bb49997 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  bd031a5e0b7d2923e36ca5958c5074f40dc64848 
> 
> Diff: https://reviews.apache.org/r/32014/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to