-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76692
-----------------------------------------------------------


Master (2f99106) is red with this patch.
  ./build-support/jenkins/build.sh

Note: Recompile with -Xlint:unchecked for details.

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizingParam.java:67:37:
 '{' is not followed by whitespace.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java:1:
 Line does not match expected header line of '^\/\*\*$'.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 47.784 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 17, 2015, 1:29 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32141/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 1:29 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1187
>     https://issues.apache.org/jira/browse/AURORA-1187
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an AnnotatedAuroraAdmin subclass for AuroraAdmin.Iface and change code to 
> inherit from it. This gives us a place to put annotations like the 
> AuthorizingParam one introduced in this review without needing to copy-paste 
> them when we override a new method. A future diff will use these annotations 
> to determine which permission a method call needs by inspecting the annotated 
> parameter. I created a new interface to enable DRY - otherwise I'd need to 
> annotate both ForwardingThrift and SchedulerThriftInterface and keep them in 
> sync.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizingParam.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c60d1e78e0f5c474ff0dcf6393e0c305d865bded 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
> b1d633602f3fb021a026a087b91d41580798eeaf 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
>  f0e40b646092e96955fddc46c3a1e62a8237b00f 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> df6b53a524b005cd5fabb099fd0c08d83e3b287d 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  ee98f66de7f671018fa0a0b4894f114c7a283eda 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 3900c2228038668576cdbb37e87127246a33317c 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 
> 7b1bf2ef8b413d2c1a08b41722a04af091305304 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
>  7e20aaa6836bd205261afe5b1244fb6af8a56356 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java
>  aae5cd7709abe3896c2ae06c218a0c90ca11c576 
> 
> Diff: https://reviews.apache.org/r/32141/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to