----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76784 -----------------------------------------------------------
src/main/python/apache/aurora/executor/common/path_detector.py <https://reviews.apache.org/r/32013/#comment124450> What's the rationale behind this change? I think the callers should be doing the checking for existance and dealing with missing directories as needed. - Zameer Manji On March 16, 2015, 3:37 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32013/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 3:37 p.m.) > > > Review request for Aurora, Joe Smith and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > SSIA > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/path_detector.py > e4135cca09b43e204c52774b747f74212d0a5732 > src/main/python/apache/thermos/observer/detector.py > 5347cded7061b085b135d62fdb3a5c4a75f81e5c > src/test/python/apache/aurora/executor/common/test_path_detector.py > 2d6edae420c1c5b51fe93f97e04c24976afacd51 > src/test/python/apache/thermos/core/test_process.py > e261249b977802851ffc3d89437761c532fcd3f8 > > Diff: https://reviews.apache.org/r/32013/diff/ > > > Testing > ------- > > ./pants test src/test/python/apache/thermos/observer:: + manual observation > > > Thanks, > > Brian Wickman > >
