> On March 17, 2015, 7:56 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java, > > line 39 > > <https://reviews.apache.org/r/32141/diff/5/?file=898006#file898006line39> > > > > Can you add a corresponding comment to api.thrift that any new methods > > (or parameters?) added should be added (or updated?) here. > > Kevin Sweeney wrote: > I'll followup with a test case that ensures all > AuroraSchedulerManager.Iface methods are represented here.
Even better, thanks! - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76787 ----------------------------------------------------------- On March 17, 2015, 8:03 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32141/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 8:03 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1187 > https://issues.apache.org/jira/browse/AURORA-1187 > > > Repository: aurora > > > Description > ------- > > Add an AnnotatedAuroraAdmin subclass for AuroraAdmin.Iface and change code to > inherit from it. This gives us a place to put annotations like the > AuthorizingParam one introduced in this review without needing to copy-paste > them when we override a new method. A future diff will use these annotations > to determine which permission a method call needs by inspecting the annotated > parameter. I created a new interface to enable DRY - otherwise I'd need to > annotate both ForwardingThrift and SchedulerThriftInterface and keep them in > sync. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizingParam.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 6b15bfdf727e2db57327936a0341d5dce98bd47c > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > d9184eb540b82c988e7ac590d5cff441f37e62fb > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java > f0e40b646092e96955fddc46c3a1e62a8237b00f > src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java > df6b53a524b005cd5fabb099fd0c08d83e3b287d > > src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java > ee98f66de7f671018fa0a0b4894f114c7a283eda > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 3900c2228038668576cdbb37e87127246a33317c > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > 7b1bf2ef8b413d2c1a08b41722a04af091305304 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java > 7e20aaa6836bd205261afe5b1244fb6af8a56356 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java > aae5cd7709abe3896c2ae06c218a0c90ca11c576 > > Diff: https://reviews.apache.org/r/32141/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Kevin Sweeney > >
