-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32225/#review77143
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On March 20, 2015, 12:25 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32225/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 12:25 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1158
>     https://issues.apache.org/jira/browse/AURORA-1158
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding a preemptor slot search perf benchmark. Below are the results for 
> synchronous (Before) and asynchronous (After) preemptor. 
> 
> Before:
> ```
> Benchmark                                                                     
> Mode  Cnt         Score        Error  Units
> SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark    
> avgt  100    781243.004 ±   9308.450  ns/op
> SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark  
> avgt  100   1205278.826 ±  19800.452  ns/op
> SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark   
> avgt  100  77048458.974 ± 918593.702  ns/op
> SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark  
> avgt  100    769919.326 ±  18963.264  ns/op
> ```
> After:
> ```
> Benchmark                                                                     
> Mode  Cnt        Score       Error  Units
> SchedulingBenchmarks.ClusterFullUtilizationBenchmark.runBenchmark             
> avgt  100     3062.264 ±   323.854  ns/op
> SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark    
> avgt  100    22135.031 ±   703.886  ns/op
> SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark  
> avgt  100   283028.184 ±  1954.987  ns/op
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
> avgt  100  3338470.414 ± 31189.009  ns/op
> SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark  
> avgt  100    22177.423 ±   589.332  ns/op
> ```
> 
> Result analysis is here: https://reviews.apache.org/r/31739/
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> ad49effdaf700bb9d5715aa5bdd1a5d0b276f83f 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
>  f817ccd23644de5aa03fe42be3a5bc2b63683a9d 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
>  c9d10e4cec44045806ec2d75d8c158dc40d7de98 
> 
> Diff: https://reviews.apache.org/r/32225/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to