----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32276/#review77153 -----------------------------------------------------------
Ship it! src/main/python/apache/aurora/client/cli/update.py <https://reviews.apache.org/r/32276/#comment125032> You can use frozenset here as well. It's a shame thrift sets are mutable by default (which causes them to be unhashable). - Kevin Sweeney On March 19, 2015, 6:53 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32276/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 6:53 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > Fixes this error: > ``` > $ aurora update list devcluster/vagrant/test/http_example --status active > Traceback (most recent call last): > File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute > self.execute_entry(entry_point, args) > File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in > execute_entry > runner(entry_point) > File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in > execute_pkg_resources > runner() > File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, > in proxy_main > File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line > 329, in execute > File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line > 306, in _execute > File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line > 382, in execute > File "apache/aurora/client/cli/update.py", line 315, in execute > TypeError: unhashable type: 'set' > ``` > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/update.py > 2168e99a315dd2916086100589c8345cd3a2c4ff > > Diff: https://reviews.apache.org/r/32276/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
