-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32295/#review77198
-----------------------------------------------------------
Master (db79418) is red with this patch.
./build-support/jenkins/build.sh
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.app-0.3.0-py2.7-nspkg.pth
Running setup.py install for GitPython
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/setuptools/dist.py:292:
UserWarning: The version specified ('0.3.2 RC1') is an invalid version, this
may not work as expected with newer versions of setuptools, pip, and PyPI.
Please see PEP 440 for more details.
"details." % self.metadata.version
Running setup.py install for pep8
Installing pep8 script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for pyflakes
Installing pyflakes script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for twitter.checkstyle
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.checkstyle-0.1.0-py2.7-nspkg.pth
Installing twitterstyle script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0
twitter.common.options-0.3.0 twitter.common.process-0.3.0
twitter.common.string-0.3.0 twitter.common.util-0.3.0
E501:ERROR src/main/python/apache/aurora/common/http_signaler.py:085 line too
long (107 > 100 characters)
| def __call__(self, endpoint, use_post_method=False,
expected_response=None, expected_response_code=None):
E303:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:066 too
many blank lines (2)
| def test_health_checks(self):
E501:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:073
line too long (107 > 100 characters)
| 'http://localhost:%s/health' % self.PORT, None,
timeout=1.0).AndReturn(OpenedURL('not ok', code=200))
E501:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:075
line too long (103 > 100 characters)
| 'http://localhost:%s/health' % self.PORT, None,
timeout=1.0).AndReturn(OpenedURL('ok', code=400))
E501:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:080
line too long (103 > 100 characters)
| 'http://localhost:%s/health' % self.PORT, None,
timeout=1.0).AndReturn(OpenedURL('ok', code=200))
E501:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:082
line too long (102 > 100 characters)
| 'http://localhost:%s/random/endpoint' % self.PORT, None,
timeout=1.0).AndReturn(OpenedURL('ok'))
T302:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:028
Expected 2 blank lines, found 1
|class OpenedURL(object):
T302:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:042
Expected 2 blank lines, found 1
|class TestHttpSignaler(unittest.TestCase):
T301:ERROR src/test/python/apache/aurora/common/test_http_signaler.py:066
Expected 1 blank lines, found 2
| def test_health_checks(self):
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 20, 2015, 10:57 a.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32295/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 10:57 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-316
> https://issues.apache.org/jira/browse/AURORA-316
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This allows the endpoint, expected response
> and expected response code to be configured by the user.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md af332f2
> src/main/python/apache/aurora/common/http_signaler.py e3e819d
> src/main/python/apache/aurora/config/schema/base.py a87524a
> src/main/python/apache/aurora/executor/common/health_checker.py cfc29c3
> src/test/python/apache/aurora/common/test_http_signaler.py f5f8419
> src/test/python/apache/aurora/executor/common/test_health_checker.py
> 1b4423a
>
> Diff: https://reviews.apache.org/r/32295/diff/
>
>
> Testing
> -------
>
> Unittests added and manurally verified in vagrant enviroment.
>
>
> Thanks,
>
> Brian Brazil
>
>
