-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/#review77273
-----------------------------------------------------------
Master (f12d9fe) is red with this patch.
./build-support/jenkins/build.sh
:startScripts
:distTar
:distZip
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/http/api/security/FieldGetterDagTest.java:22:
error: cannot find symbol
import org.apache.aurora.gen.storage.StoredJob;
^
symbol: class StoredJob
location: package org.apache.aurora.gen.storage
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/http/api/security/FieldGetterDagTest.java:22:
error: cannot find symbol
import org.apache.aurora.gen.storage.StoredJob;
^
symbol: class StoredJob
location: package org.apache.aurora.gen.storage
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/http/api/security/FieldGetterDagTest.java:63:
error: cannot find symbol
assertNull(jobKeyFieldGetterDag.getterFor(StoredJob.class).orNull());
^
symbol: class StoredJob
location: class FieldGetterDagTest
2 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 47.53 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 20, 2015, 8:23 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32329/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 8:23 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-1187
> https://issues.apache.org/jira/browse/AURORA-1187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Apologies for the large diff, this wound up needing to input validation at
> the AOP layer.
>
> Probably the best place to start reading this diff is ApiSecurityIT to see
> the feature this patch enables.
>
> Also the best place to start reviewing FieldGetterDag is also its tests and
> usage.
>
>
> Diffs
> -----
>
> config/pmd/custom.xml 521fd500146eb2e45f8e77c5c3c0cce330fedabb
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java
> 827e85b6cac8bd52359610bbc2002973a769705c
> src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java
> 2408cd1f9af5f109a339f5c78134465cb117f7fc
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
> cc9cfd38239f909b8a77bd1a773e31ec30130d41
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizingParam.java
> 808987939b2c4a850e488dc033b50b0178e95ba0
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetterDag.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthenticatingThriftInterceptor.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java
> 4e341e05c34b1be38f0040c26b671a0cc797a771
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/StructFieldGetter.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/StructGetter.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/StructGetters.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> 5588d1793d6713ee4581ac9f938d9a8689acb315
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java
> bdd2185f3a7a94b39bcec3c73455e970d87f0c6a
> src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java
> cafd10f6b705568588c1b92644b482003242fe2e
> src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java
> ed284f46ac8f01bd6d9e317f995f16d6e666a68d
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
> 76cb691e6d7d4fada3a18fde73aceed7039bcaa4
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/FieldGetterDagTest.java
> PRE-CREATION
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthenticatingThriftInterceptorTest.java
> PRE-CREATION
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
> PRE-CREATION
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java
> d2ba2730c4509dc9a636fd32e9244b0d7fa2884f
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/StructFieldGetterTest.java
> PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
> 1f24e7d47e1f777ffef19a73d01171fcacd31cdb
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java
> d20c9da3c4944ec8c50fe8d48b7e459ff1c7082b
>
> Diff: https://reviews.apache.org/r/32329/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
