> On March 21, 2015, 12:14 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java, 
> > line 66
> > <https://reviews.apache.org/r/32359/diff/1/?file=902147#file902147line66>
> >
> >     The description should state the intent of the option more explicitly. 
> > Even reading the code did  not help me much.
> >     
> >     Only the description in the associated Jira ticket helps to undestand 
> > why this option is important and might need to be tuned.

Thanks, added more details. Let me know if you still think it's not clear or 
have another alternative.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/#review77337
-----------------------------------------------------------


On March 21, 2015, 2:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32359/
> -----------------------------------------------------------
> 
> (Updated March 21, 2015, 2:22 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1211
>     https://issues.apache.org/jira/browse/AURORA-1211
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding a configurable delay into writing a backup file.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> a6b187d888726b921733a36fcaecdab97bdef094 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 
> 569648aea2ccdb57663d16b7c837fd2677694419 
>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
> 5853c037d53e707e5df434fc661cd285ed9ecfc4 
>   
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java
>  ebe551739fb6b7132ce666ad9b3c5a86e90a5363 
> 
> Diff: https://reviews.apache.org/r/32359/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to