----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32371/#review77667 -----------------------------------------------------------
Ship it! Ship It! - Maxim Khutornenko On March 21, 2015, 7:42 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32371/ > ----------------------------------------------------------- > > (Updated March 21, 2015, 7:42 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > I found myself in here while doing some exploratory changes to `TaskStore`. > I started by using `IAssignedTask` and `ITaskConfig` where possible, rather > than `IScheduledTask`, and that snowballed into a refactor to extract common > functions and predicates. > > Feel free to push back if you feel this reduces readability or seems like > code shuffling with little gain. One upside to this outcome is the imminent > post-JDK8 lambda refactor will cause this diff to be a net reduction in code. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java > 39e930c4bfe716765908c6d78b58c831b6fb341b > src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java > b53086169aa53d27a39a01cadf8d3c4a8ecb68de > src/main/java/org/apache/aurora/scheduler/updater/Updates.java > 776278cb64c7ce0419a692143e458801e3b1c37f > > Diff: https://reviews.apache.org/r/32371/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
