Github user ckadner commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/27#discussion_r88360001
  
    --- Diff: pom.xml ---
    @@ -446,6 +447,7 @@
                   <exclude>.classpath</exclude>
                   <exclude>.project</exclude>
                   <exclude>**/dependency-reduced-pom.xml</exclude>
    +              
<exclude>**/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister</exclude>
    --- End diff --
    
    @lresende even though 
[java.util.ServiceLoader](http://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html)
 ignores `#`-comment lines I did not see any examples of it being used in 
DataSourceRegister files of other projects &mdash; i.e. Spark does not include 
license comments in its 3 DataSourceRegister service provider configuration 
files. What's wrong with excluding it from the RAT license checks?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to