Github user ckadner commented on the issue:

    https://github.com/apache/bahir/pull/38
  
    @sbcd90 -- thanks for you continuous updates and sorry for the piecemeal 
review from my end  ... I started with your test cases since we were still in 
the process of fixing our Jenkins build setup. But your test cases are great 
now :-)
    
    Perhaps more important, my first request to you should have been to add a 
README and examples so users can start using your connector without having to 
read through too much code ... i.e. please further follow the precedence set by 
`sql-streaming-mqtt`.
    
    **Thank you!**


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to